Skip to content

Fix experimental labels#2331

Merged
rapids-bot[bot] merged 14 commits intorapidsai:branch-22.08from
alexbarghi-nv:fix-experimental-labels
Jun 17, 2022
Merged

Fix experimental labels#2331
rapids-bot[bot] merged 14 commits intorapidsai:branch-22.08from
alexbarghi-nv:fix-experimental-labels

Conversation

@alexbarghi-nv
Copy link
Member

@alexbarghi-nv alexbarghi-nv commented Jun 2, 2022 •
edited
Loading

Resolves #2315
Resolves #2303

@alexbarghi-nv alexbarghi-nv self-assigned this Jun 3, 2022
@alexbarghi-nv alexbarghi-nv added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python labels Jun 3, 2022
@BradReesWork BradReesWork added this to the 22.08 milestone Jun 3, 2022
betochimas
betochimas reviewed Jun 3, 2022
View reviewed changes
@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review June 3, 2022 19:32
@alexbarghi-nv alexbarghi-nv requested a review from a team as a code owner June 3, 2022 19:32
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@95824f8). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08    #2331   +/-   ##
===============================================
  Coverage                ?   61.05%           
===============================================
  Files                   ?      102           
  Lines                   ?     5074           
  Branches                ?        0           
===============================================
  Hits                    ?     3098           
  Misses                  ?     1976           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95824f8...683dfd7. Read the comment docs.

@alexbarghi-nv
Copy link
Member Author

alexbarghi-nv commented Jun 8, 2022

added changes to close #2303

@alexbarghi-nv
Copy link
Member Author

alexbarghi-nv commented Jun 15, 2022

rerun tests

@alexbarghi-nv
Copy link
Member Author

alexbarghi-nv commented Jun 16, 2022

@rlratzel
@jnke2016
This is ready for review now.

jnke2016
jnke2016 approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@jnke2016 jnke2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rlratzel
Copy link
Contributor

rlratzel commented Jun 17, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 78b394c into rapidsai:branch-22.08 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rlratzel rlratzel rlratzel approved these changes

@jnke2016 jnke2016 jnke2016 approved these changes

@acostadon acostadon Awaiting requested review from acostadon

+1 more reviewer

@betochimas betochimas betochimas left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@alexbarghi-nv alexbarghi-nv

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Milestone

22.08

Development

Successfully merging this pull request may close these issues.

[FIX] Ensure stable pylibcugraph API calls do not produce an experimental warning [FEA] migrate contents of proto to experimental and remove proto

6 participants

@alexbarghi-nv @codecov-commenter @rlratzel @jnke2016 @betochimas @BradReesWork