Skip to content

Default GPU_COUNT to 1 in cmake file#2336

Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-22.08from
ChuckHastings:fix_2314
Jun 6, 2022
Merged

Default GPU_COUNT to 1 in cmake file#2336
rapids-bot[bot] merged 1 commit intorapidsai:branch-22.08from
ChuckHastings:fix_2314

Conversation

@ChuckHastings
Copy link
Collaborator

Closes #2314

Rather than relying on the output from nvidia-smi, MG C++ tests will default to 1 GPU. This default can be overridden by the developer by calling cmake with the option: -DGPU_COUNT= and specifying the desired number of GPUs.

Note that the user can always run individual tests by directly calling mpirun. This only affects the default used by ctest, make test or ninja test to run the entire suite of tests.

@ChuckHastings ChuckHastings requested a review from a team as a code owner June 3, 2022 19:59
@ChuckHastings ChuckHastings self-assigned this Jun 3, 2022
@ChuckHastings ChuckHastings added this to the 22.08 milestone Jun 3, 2022
@ChuckHastings ChuckHastings added bug Something isn't working improvement Improvement / enhancement to an existing function and removed bug Something isn't working labels Jun 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@5ae30cc). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 54b84e4 differs from pull request most recent head be6282e. Consider uploading reports for the commit be6282e to get more accurate results

@@               Coverage Diff               @@
##             branch-22.08    #2336   +/-   ##
===============================================
  Coverage                ?   60.74%           
===============================================
  Files                   ?      105           
  Lines                   ?     5075           
  Branches                ?        0           
===============================================
  Hits                    ?     3083           
  Misses                  ?     1992           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ae30cc...be6282e. Read the comment docs.

@rlratzel
Copy link
Contributor

rlratzel commented Jun 6, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 305662f into rapidsai:branch-22.08 Jun 6, 2022
@ChuckHastings ChuckHastings deleted the fix_2314 branch August 4, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] cpp/tests/CMakeLists.txt requires nvidia-smi and doesn't check the exit code

3 participants