[REVIEW]Fix Fanout -1#2358
Merged
rapids-bot[bot] merged 6 commits intorapidsai:branch-22.08from Jun 16, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #2358 +/- ##
===============================================
Coverage ? 60.76%
===============================================
Files ? 105
Lines ? 5077
Branches ? 0
===============================================
Hits ? 3085
Misses ? 1992
Partials ? 0 Continue to review full report at Codecov.
|
alexbarghi-nv
approved these changes
Jun 16, 2022
Member
Author
Added that. Also for full visibility this makes it align with the DGL behavior mentioned here. |
Contributor
|
@gpucibot merge |
nv-rliu
pushed a commit
to nv-rliu/cugraph-gnn
that referenced
this pull request
Jul 15, 2025
This PR fixes sampling when for the default value of -1 which is called below: https://github.com/rapidsai/cugraph/blob/92f6ba451b2d9e6c3f60dbccfa05bbf3c480e43a/python/cugraph/cugraph/gnn/graph_store.py#L129-L133 In workflows this is called during inference so we need this to work for inference to work .with CuGraphStorage . Authors: - Vibhu Jawa (https://github.com/VibhuJawa) Approvers: - Rick Ratzel (https://github.com/rlratzel) - Alex Barghi (https://github.com/alexbarghi-nv) URL: rapidsai/cugraph#2358
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes sampling when for the default value of -1 which is called below:
cugraph/python/cugraph/cugraph/gnn/graph_store.py
Lines 129 to 133 in 92f6ba4
In workflows this is called during inference so we need this to work for inference to work .with CuGraphStorage .