Refactor MG C++ tests (handle initialization)#2439
Merged
rapids-bot[bot] merged 19 commits intorapidsai:branch-22.08from Jul 27, 2022
Merged
Refactor MG C++ tests (handle initialization)#2439rapids-bot[bot] merged 19 commits intorapidsai:branch-22.08from
rapids-bot[bot] merged 19 commits intorapidsai:branch-22.08from
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #2439 +/- ##
===============================================
Coverage ? 61.30%
===============================================
Files ? 106
Lines ? 5398
Branches ? 0
===============================================
Hits ? 3309
Misses ? 2089
Partials ? 0 Continue to review full report at Codecov.
|
ChuckHastings
approved these changes
Jul 26, 2022
kaatish
approved these changes
Jul 26, 2022
jnke2016
approved these changes
Jul 26, 2022
Member
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update MG C++ tests to initialize a RAFT handle_t object in SetUpTestCase().
Previously, a handle_t object is initialized inside individual tests. If an exception is thrown inside a single test, a stack unwinding process starts, and this calls handle_t's destructor, and the destructor invokes ncclCommDestroy(). If only a subset of workers fail, some processes will still advance and can be blocked on a NCCL call, This bars ncclCommDestroy() from finishing, and the stack unwinding process will hang. The outcome is no output in the console and testers may have no clue that exceptions are thrown.
With this restructuring, exceptions in individual tests will not destroy a handle_t object, so testers will see the exception messages.