Use Datasets API to Update Notebook Examples#2440
Merged
rapids-bot[bot] merged 19 commits intorapidsai:branch-22.08from Aug 2, 2022
Merged
Use Datasets API to Update Notebook Examples#2440rapids-bot[bot] merged 19 commits intorapidsai:branch-22.08from
rapids-bot[bot] merged 19 commits intorapidsai:branch-22.08from
Conversation
added 2 commits
July 25, 2022 07:40
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…to datasets-api-nb
acostadon
added
Notebook
improvement
rlratzel
approved these changes
Jul 28, 2022
Contributor
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
Looks good. I had one minor suggestion and an observation which need not hold up approval.
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "# You can also just get the edgelist\n", |
Contributor
There was a problem hiding this comment.
I would just remove this comment since it's probably not needed, and it sounds a little less formal that the others anyway.
Comment on lines
+214
to
+215
| "G = karate.get_graph()\n", | ||
| "G = G.to_undirected()" |
Contributor
There was a problem hiding this comment.
This change is perhaps out-of-scope for this PR, but it would be nice if get_graph accepted a create_using option similar to cugraph.from_edgelist that allowed you to get a directed or undirected graph.
Member
|
rerun tests |
Contributor
|
@gpucibot merge |
1 similar comment
Member
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #2364
All of the SG notebook examples have been updated to use the newly added Datasets API. Previously, Graph objects were created by specifying a path to the
.csvfile, callingcuDFto read in the file, and then converting the edge list to a graph.Now, a dataset object is imported and can create graphs by calling the
get_graph()method. Comments and headings have also been updated for continuity.