[REVIEW]Uniform neighbor sample by VibhuJawa · Pull Request #2450 · rapidsai/cugraph

VibhuJawa · 2022-07-27T06:41:33Z

This PR switches cugraphstore to use uniform neighbor sampling.

Opening this in favor of #2426

VibhuJawa · 2022-07-27T06:44:57Z

python/cugraph/cugraph/gnn/graph_store.py

+            source=src_n,
+            destination=dst_n,
+            edge_attr="weight",
+            renumber=False,


May need to switch to renumber=True.

See issue: #2446

renumber=True. still is causing errors. Todo: Raise a MRE without it and comment to the issue.

legacy_renum_only=True

python/cugraph/cugraph/gnn/graph_store.py

rlratzel

Looks good, just a comment and a couple of minor suggestions.

python/cugraph/cugraph/gnn/graph_store.py

alexbarghi-nv

Looks fine; just make sure all the subgraphs are being created with legacy_renum_only=True

review-notebook-app · 2022-07-29T17:54:25Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

alexbarghi-nv

👍

codecov-commenter · 2022-07-29T19:28:55Z

Codecov Report

Merging #2450 (911b866) into branch-22.08 (1a29434) will increase coverage by 38.11%.
The diff coverage is 91.42%.

@@                Coverage Diff                @@
##           branch-22.08    #2450       +/-   ##
=================================================
+ Coverage         23.10%   61.22%   +38.11%     
=================================================
  Files               106      106               
  Lines              5539     5568       +29     
=================================================
+ Hits               1280     3409     +2129     
+ Misses             4259     2159     -2100

Impacted Files	Coverage Δ
python/cugraph/cugraph/gnn/graph_store.py	`79.24% <91.42%> (+50.07%)`	⬆️
.../cugraph/cugraph/experimental/datasets/__init__.py	`100.00% <0.00%> (ø)`
python/cugraph/cugraph/dask/comms/comms.py	`34.06% <0.00%> (+5.49%)`	⬆️
python/cugraph/cugraph/generators/rmat.py	`25.96% <0.00%> (+12.50%)`	⬆️
python/cugraph/cugraph/dask/traversal/bfs.py	`33.33% <0.00%> (+13.33%)`	⬆️
python/cugraph/cugraph/testing/utils.py	`79.14% <0.00%> (+33.12%)`	⬆️
python/cugraph/cugraph/link_prediction/overlap.py	`59.09% <0.00%> (+36.36%)`	⬆️
python/cugraph/cugraph/linear_assignment/lap.py	`71.42% <0.00%> (+42.85%)`	⬆️
python/cugraph/cugraph/layout/force_atlas2.py	`61.11% <0.00%> (+44.44%)`	⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a29434...911b866. Read the comment docs.

VibhuJawa · 2022-07-29T20:12:57Z

@gpucibot rerun tests

…i#2473) Updated imports to be compatible with latest version of cupy and also changed corresponding scipy imports for consistency. Authors: - Rick Ratzel (https://github.com/rlratzel) Approvers: - Brad Rees (https://github.com/BradReesWork) URL: rapidsai#2473

rlratzel · 2022-08-01T13:29:46Z

rerun tests

#2473 was merged which should resolve test failures.

ajschmidt8 · 2022-08-01T15:58:24Z

Removing ops-codeowners from the required reviews since it doesn't seem there are any file changes that we're responsible for. Feel free to add us back if necessary.

VibhuJawa · 2022-08-01T16:10:33Z

@gpucibot rerun tests

There might be some weirdness around sampling on different CUDA versions. Testing it. Lets hold of merging even if CI is passing.

VibhuJawa · 2022-08-02T01:46:24Z

@gpucibot rerun tests

Rerunning cause the gpuCI/cugraph/gpu/cuda/11.2/driver-495/python/3.9/ubuntu18.04 build timed out with below. All other tests passed.

17:37:26 Download error (28) Timeout was reached [https://conda.anaconda.org/rapidsai-nightly/linux-64/dask-cuda-22.08.00a220801-py39_g283a087_32.tar.bz2]
17:37:26 SSL connection timeout

rlratzel

Tests and code look good. I did file this so we can address the FIXMEs ASAP in 22.10

rlratzel · 2022-08-02T21:38:41Z

@gpucibot merge

This PR switches `cugraphstore` to use uniform neighbor sampling. Opening this in favor of rapidsai/cugraph#2426 Authors: - Vibhu Jawa (https://github.com/VibhuJawa) - Rick Ratzel (https://github.com/rlratzel) Approvers: - Alex Barghi (https://github.com/alexbarghi-nv) - Rick Ratzel (https://github.com/rlratzel) URL: rapidsai/cugraph#2450

working sampling code with tests

8ffbc95

VibhuJawa requested a review from a team as a code owner July 27, 2022 06:41

VibhuJawa added feature request New feature or request improvement Improvement / enhancement to an existing function GNN non-breaking Non-breaking change labels Jul 27, 2022

VibhuJawa mentioned this pull request Jul 27, 2022

[WIP]Uniform neighbor sample #2426

Closed

VibhuJawa removed the feature request New feature or request label Jul 27, 2022

VibhuJawa commented Jul 27, 2022

View reviewed changes

VibhuJawa requested review from alexbarghi-nv and rlratzel July 27, 2022 06:47

BradReesWork added this to the 22.08 milestone Jul 27, 2022

VibhuJawa added 2 commits July 27, 2022 17:19

Switch renumber=True

3e99193

use extracted_subgraph_without_renumbering

7ec5830

rlratzel reviewed Jul 28, 2022

View reviewed changes

python/cugraph/cugraph/gnn/graph_store.py Show resolved Hide resolved

python/cugraph/cugraph/gnn/graph_store.py Show resolved Hide resolved

python/cugraph/cugraph/gnn/graph_store.py Show resolved Hide resolved

alexbarghi-nv reviewed Jul 28, 2022

View reviewed changes

python/cugraph/cugraph/gnn/graph_store.py Outdated Show resolved Hide resolved

alexbarghi-nv reviewed Jul 28, 2022

View reviewed changes

VibhuJawa added 5 commits July 28, 2022 15:16

Added legacy_renum_only=True and FIXME links to relevant PRs and Issues

fd10c8c

working sampling code with tests

a6b2bf8

Switch renumber=True

597126f

use extracted_subgraph_without_renumbering

556cc73

Fix conflicts

3704b9a

VibhuJawa changed the base branch from branch-22.08 to branch-22.10 July 29, 2022 17:55

VibhuJawa requested review from a team as code owners July 29, 2022 17:55

VibhuJawa changed the base branch from branch-22.10 to branch-22.08 July 29, 2022 17:55

alexbarghi-nv approved these changes Jul 29, 2022

View reviewed changes

ajschmidt8 removed the request for review from a team August 1, 2022 15:58

VibhuJawa added 11 commits August 1, 2022 15:42

Updated graph_store to cast seed dtype

d992b05

working sampling code with tests

404afb8

Switch renumber=True

8a6d1c3

use extracted_subgraph_without_renumbering

81e2db4

Added legacy_renum_only=True and FIXME links to relevant PRs and Issues

f2fd164

working sampling code with tests

aba911c

Switch renumber=True

829a580

Updated graph_store to cast seed dtype

3f58e46

Fix typo of sg.edgelist.edgelist_df

7e28d4d

Resolving conflicts

260bc00

Removed typo cudf.sfrom_dlpack

911b866

VibhuJawa requested review from a team and removed request for a team August 2, 2022 20:29

rlratzel mentioned this pull request Aug 2, 2022

[FEA] Remove code that uses PropertyGraph debug/internal attrs from gnn modules #2480

Closed

rlratzel approved these changes Aug 2, 2022

View reviewed changes

rapids-bot bot merged commit d50622f into rapidsai:branch-22.08 Aug 2, 2022

Conversation

VibhuJawa commented Jul 27, 2022

Uh oh!

VibhuJawa Jul 27, 2022

Choose a reason for hiding this comment

Uh oh!

VibhuJawa Jul 28, 2022

Choose a reason for hiding this comment

Uh oh!

alexbarghi-nv Jul 28, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rlratzel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexbarghi-nv left a comment

Choose a reason for hiding this comment

Uh oh!

review-notebook-app bot commented Jul 29, 2022

Uh oh!

alexbarghi-nv left a comment

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Jul 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

VibhuJawa commented Jul 29, 2022

Uh oh!

rlratzel commented Aug 1, 2022

Uh oh!

ajschmidt8 commented Aug 1, 2022

Uh oh!

VibhuJawa commented Aug 1, 2022

Uh oh!

VibhuJawa commented Aug 2, 2022

Uh oh!

rlratzel left a comment

Choose a reason for hiding this comment

Uh oh!

rlratzel commented Aug 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov-commenter commented Jul 29, 2022 •

edited

Loading