Skip to content

Change default return type PropertyGraph.extract_subgraph() -> cugraph.Graph(directed=True)#2460

Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-22.08from
eriknw:pg_to_directed_graph
Jul 28, 2022
Merged

Change default return type PropertyGraph.extract_subgraph() -> cugraph.Graph(directed=True)#2460
rapids-bot[bot] merged 1 commit intorapidsai:branch-22.08from
eriknw:pg_to_directed_graph

Conversation

@eriknw
Copy link
Contributor

@eriknw eriknw commented Jul 28, 2022

Fixes #2459

The tests already specify the use of directed graphs most places, so this required minimal changes.

@eriknw eriknw requested a review from a team as a code owner July 28, 2022 02:35
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@d925926). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08    #2460   +/-   ##
===============================================
  Coverage                ?   61.26%           
===============================================
  Files                   ?      106           
  Lines                   ?     5404           
  Branches                ?        0           
===============================================
  Hits                    ?     3311           
  Misses                  ?     2093           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d925926...29f7b9c. Read the comment docs.

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick response!

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function breaking Breaking change labels Jul 28, 2022
@rlratzel rlratzel added this to the 22.08 milestone Jul 28, 2022
@rlratzel
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit aca180a into rapidsai:branch-22.08 Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking change improvement Improvement / enhancement to an existing function

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEA] Change the default for Graph instances returned by PropertyGraph.extract_subgraph() to directed

3 participants