fix non-deterministic bug in uniform neighborhood sampling#2477
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-22.08from Aug 2, 2022
Merged
Conversation
ChuckHastings
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #2477 +/- ##
===============================================
Coverage ? 61.21%
===============================================
Files ? 106
Lines ? 5553
Branches ? 0
===============================================
Hits ? 3399
Misses ? 2154
Partials ? 0 Continue to review full report at Codecov.
|
Collaborator
Author
|
rerun tests |
alexbarghi-nv
approved these changes
Aug 2, 2022
Member
alexbarghi-nv
left a comment
alexbarghi-nv
left a comment
There was a problem hiding this comment.
@ChuckHastings this has fixed the error on my side.
seunghwak
approved these changes
Aug 2, 2022
Collaborator
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a bug in uniform neighborhood sampling. Called a function that returns an optional. In SG mode the optional is always null. It was being dereferenced and passed to a function where random memory contents were being used.
Fixed the SG code to not use those values.
Closes #2446