[REVIEW]Hetrograph and dask_cudf support#2592
Merged
rapids-bot[bot] merged 25 commits intorapidsai:branch-22.10from Sep 30, 2022
Merged
[REVIEW]Hetrograph and dask_cudf support#2592rapids-bot[bot] merged 25 commits intorapidsai:branch-22.10from
rapids-bot[bot] merged 25 commits intorapidsai:branch-22.10from
Conversation
BradReesWork
added
improvement
rlratzel
approved these changes
Aug 23, 2022
VibhuJawa
changed the title
VibhuJawa
force-pushed
the
heto_graph_support
branch
2 times, most recently
from
46cd9dd to
2bd6dd3
Compare
VibhuJawa
force-pushed
the
heto_graph_support
branch
from
2bd6dd3 to
bd5a5cf
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #2592 +/- ##
===============================================
Coverage ? 58.79%
===============================================
Files ? 111
Lines ? 6184
Branches ? 0
===============================================
Hits ? 3636
Misses ? 2548
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
VibhuJawa
changed the title
BradReesWork
approved these changes
Sep 30, 2022
Member
|
rerun tests |
Member
|
@gpucibot merge |
nv-rliu
pushed a commit
to nv-rliu/cugraph-gnn
that referenced
this pull request
Jul 15, 2025
This PR fixes rapidsai/graph_dl#27 This PR fixes rapidsai/graph_dl#43 This PR fixes rapidsai/graph_dl#39 **Tests Added:** Single GPU: - [x] APIs like num_nodes, num_edges - [x] test_sampling_basic - [x] test_sampling_homogeneous_gs_in_dir - [x] test_sampling_homogeneous_gs_out_dir - [x] test_sampling_gs_homogeneous_neg_one_fanout - [x] test_sampling_gs_heterogeneous_in_dir - [x] test_sampling_gs_heterogeneous_out_dir - [x] test_sampling_gs_heterogeneous_neg_one_fanout Multi GPU: - [x] APIs like num_nodes, num_edges - [x] test_sampling_basic - [x] test_sampling_homogeneous_gs_in_dir - [x] test_sampling_homogeneous_gs_out_dir - [x] test_sampling_gs_homogeneous_neg_one_fanout - [x] test_sampling_gs_heterogeneous_in_dir - [x] test_sampling_gs_heterogeneous_out_dir - [x] test_sampling_gs_heterogeneous_neg_one_fanout Bugs to reproduce: - [ ] Repro heterogeneous single gpu hang outside pytest - [x] Repro hetrogenous multi gpu incorrect results for with_replace=False rapidsai/cugraph#2760 - [x] Repro hetrogenous incorrect results for different amount of GPUs rapidsai/cugraph#2761 Tests that depend upon rapidsai/cugraph#2523 - [x] Add minimal example to PR to ensure it gets fixed Added comment here: rapidsai/cugraph#2523 (review) - [x] test_get_node_storage_gs (Failing cause of a PG bug) - [x] test_get_edge_storage_gs (Failing cause of a PG bug) - [x] test_get_node_storage_gs (Failing cause of a PG bug) - [x] test_get_edge_storage_gs (Failing cause of a PG bug) Authors: - Vibhu Jawa (https://github.com/VibhuJawa) Approvers: - Rick Ratzel (https://github.com/rlratzel) - Brad Rees (https://github.com/BradReesWork) URL: rapidsai/cugraph#2592
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes https://github.com/rapidsai/graph_dl/issues/27
This PR fixes https://github.com/rapidsai/graph_dl/issues/43
This PR fixes https://github.com/rapidsai/graph_dl/issues/39
Tests Added:
Single GPU:
Multi GPU:
Bugs to reproduce:
[BUG] dask.uniform_neighbor_sample gives incorrect number of samples #2760
[BUG] dask.uniform_neighbor_sample gives different results depending on the number of GPUs used #2761
Tests that depend upon #2523
Added comment here: PropertyGraph set index to vertex and edge ids #2523 (review)