Promote triangle count from experimental#2671
Merged
rapids-bot[bot] merged 32 commits intorapidsai:branch-22.10from Sep 19, 2022
Merged
Promote triangle count from experimental#2671rapids-bot[bot] merged 32 commits intorapidsai:branch-22.10from
rapids-bot[bot] merged 32 commits intorapidsai:branch-22.10from
Conversation
…t32', add support for 'start_list' parameter
…rameter 'start_list'
…nd update the init file
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…0_promote-triangle-count
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #2671 +/- ##
===============================================
Coverage ? 60.16%
===============================================
Files ? 111
Lines ? 6123
Branches ? 0
===============================================
Hits ? 3684
Misses ? 2439
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rlratzel
requested changes
Sep 9, 2022
Contributor
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
Looks good, I may have more suggestions later today but for now just some minor things.
rlratzel
added
improvement
rlratzel
approved these changes
Sep 13, 2022
Member
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to replacing the current stable
triangle_countAPI withexperimental.triangle_countand updating the docs and test, this PR also adds support for the parameterstart_listfor both the SG and the MG implementation. It also renamestriangle_counttotrianglesto be consistent with the previous APIcloses #2667