Skip to content

Add or Update Similarity algorithms#2704

Merged
rapids-bot[bot] merged 147 commits intorapidsai:branch-22.12from
jnke2016:branch-22.10_fea-similarity-algorithms
Nov 21, 2022
Merged

Add or Update Similarity algorithms#2704
rapids-bot[bot] merged 147 commits intorapidsai:branch-22.12from
jnke2016:branch-22.10_fea-similarity-algorithms

Conversation

@jnke2016
Copy link
Contributor

@jnke2016 jnke2016 commented Sep 18, 2022 •
edited
Loading

Extend the pylibcugraph similarity algorithms to python cugraph. MG implementations are now supported
closes #2690
closes #2540

ChuckHastings and others added 17 commits August 25, 2022 16:16
@ChuckHastings
part 1 of defining jaccard
d6df617
@ChuckHastings
add stubbed out implementations
32f8479
@ChuckHastings
fix clang-format issues
5ee1a0d
@ChuckHastings
address PR comments, add two_hop expansion, make vertex_pair required
1da7811
@ChuckHastings
add test case support for partial testing of results
e3a2a86
@ChuckHastings
Merge branch 'branch-22.10' into new_jaccard_apis
4d6dbdd
@ChuckHastings
a few more edits from PR review
500915e
@ChuckHastings
add C API tests, add stub C API calls, update based on PR comments
df2fbe8
@ChuckHastings
fix clang-format issues
8d22d15
@ChuckHastings
Merge branch 'branch-22.10' into new_jaccard_apis
d93dfd8
@jnke2016
free all pointers
dc15a47
@jnke2016
fix typo
e32e8a4
@jnke2016
extend pylibcugraph 'two_hop_neighbors' to the python cugraph API
9f10a54
@jnke2016
add 'two_hop_neighbors' and 'jaccard' to the CMakeLists and module in…
d65ca91 
…itialization
@jnke2016
create a module for MG link_prediction algorithms
b92857f
@jnke2016
extern the graph_functions to cython
36802f9
@jnke2016
define the similarity algorithms in pylibcugraph
244796f
@jnke2016
Copy link
Contributor Author

jnke2016 commented Sep 18, 2022 •
edited
Loading

@ChuckHastings Can you take a look at this PR when you get a chance? I just want to make sure graph_functions and the similarity algorithms (so far I only implemented jaccard_coefficients) are written according to the discussion in your PR (the equivalent C++ one). This PR builds successfully but doesn't run as I get a Not Implemented error at the python layer. Once I no longer get a Not Implemented, I will update pylibcugraph jaccard to extract the first and second from cugraph_vertex_pairs_t* and will return the trio and not just the similarity results.

@BradReesWork BradReesWork added this to the 22.10 milestone Sep 29, 2022
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 29, 2022
@BradReesWork BradReesWork changed the base branch from branch-22.10 to branch-22.12 October 4, 2022 13:32
@BradReesWork BradReesWork modified the milestones: 22.10, 22.12 Oct 4, 2022
@jnke2016 jnke2016 requested a review from a team as a code owner November 19, 2022 05:08
@review-notebook-app
Copy link

review-notebook-app bot commented Nov 19, 2022

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@jnke2016
fix style
cca65a8
@jnke2016
fix typo
f846a37
@jnke2016
fix typo
a4be463
@jnke2016
update docstrings example
cdc37c9
@jnke2016
remove outdated FIXME
7324920
@jnke2016
update docstrings, raise and exception for weighted graphs
a5a7812
@jnke2016
remove outdated docstrings
c119e76
@jnke2016
update docstrings and function definition, raise error for invalid in…
8c226ff 
…put value
@jnke2016
update tests
7b57136
@jnke2016
move python MG link_prediction out of experimental
ee28e0b
@jnke2016
update MG Louvain tests by adding weigths at the graph creation
4dbc24f
@jnke2016
move python MG link_prediction algos to stable
0af5afc
@jnke2016
fix typo
37acd7d
@jnke2016
raise appropriate error for invalid input
c2b9796
@jnke2016
add init file
b44d985
@jnke2016
fix typo
478de01
@jnke2016
update docstring, raise appropriate error for invalid input
2d9f001
@jnke2016
add tests for invalid input
32636c0
@jnke2016
fix style
b7c954b
@jnke2016
update docstring tests
8fcfa70
@jnke2016
add weights at the graph creation
af4f380
@BradReesWork
Copy link
Member

BradReesWork commented Nov 21, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f8746c9 into rapidsai:branch-22.12 Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@seunghwak seunghwak seunghwak approved these changes

@naimnv naimnv naimnv approved these changes

@rlratzel rlratzel Awaiting requested review from rlratzel

Assignees

@jnke2016 jnke2016

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Milestone

22.12

Development

Successfully merging this pull request may close these issues.

Add sorensen to cugraph python MNMG Jaccard - Define pylibcugraph API

6 participants

@jnke2016 @codecov-commenter @BradReesWork @ChuckHastings @seunghwak @naimnv