Skip to content

added tests for triangle count on unweighted graphs and graphs with int64 vertex types #2716

Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-22.10from
acostadon:branch-22.10_triangles
Sep 23, 2022
Merged

added tests for triangle count on unweighted graphs and graphs with int64 vertex types #2716
rapids-bot[bot] merged 1 commit intorapidsai:branch-22.10from
acostadon:branch-22.10_triangles

Conversation

@acostadon
Copy link
Contributor

closes #2615
closes #2616

replaces #2626 which was closed

@acostadon acostadon requested a review from a team as a code owner September 22, 2022 15:07
@acostadon acostadon self-assigned this Sep 22, 2022
@acostadon acostadon added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Sep 22, 2022
@acostadon acostadon added this to the 22.10 milestone Sep 22, 2022
@acostadon
Copy link
Contributor Author

rerun tests

1 similar comment
@acostadon
Copy link
Contributor Author

rerun tests

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a minor comment which need not hold up approval. Feel free to fix if you like but it can be merged without fixing if we need to merge this right away.

Gnx = input_combo["Gnx"]
count_legacy_32 = cugraph.triangle_count(Gnx)

graph_files = input_combo["graph_file"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this doesn't need to be plural (ie. there's just one file here)?

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 58477c5 into rapidsai:branch-22.10 Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FIX] Experimental Triangle count requires int32 for the vertex type [FIX] Experimental Triangle count errors out when no weights are provided

3 participants