Skip to content

Raise a warning for certain algorithms#2756

Merged
rapids-bot[bot] merged 10 commits intorapidsai:branch-22.10from
jnke2016:branch-22.10_raise-warning
Oct 3, 2022
Merged

Raise a warning for certain algorithms#2756
rapids-bot[bot] merged 10 commits intorapidsai:branch-22.10from
jnke2016:branch-22.10_raise-warning

Conversation

@jnke2016
Copy link
Contributor

@jnke2016 jnke2016 commented Sep 29, 2022

Certain algorithms (Katz, HITS, PageRank, Eigenvector centrality) require the flag store_transposed to be set to True for optimal performance. Although the CAPI internally transposed the graph at the algo's call if it wasn't at the graph creation, this adds extra overheads. This PR:

  1. Raises an exception if the user doesn't set the flag to True at the graph creation
  2. Split_out the groupby result to multiple partition instead of one.

closes #2742

@jnke2016 jnke2016 requested a review from a team as a code owner September 29, 2022 04:48
@BradReesWork BradReesWork added this to the 22.10 milestone Sep 29, 2022
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 29, 2022
@alexbarghi-nv
Copy link
Member

Shouldn't simpleDistributedGraph also include the new store_transposed property?

@jnke2016
Copy link
Contributor Author

@alexbarghi-nv store_transposed was already available in simpleDistributedGraph

Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rlratzel
Copy link
Contributor

rlratzel commented Oct 3, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2b8395a into rapidsai:branch-22.10 Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add warning in python cugraph when auto-transpose will happen

4 participants