Skip to content

remove unused mechanism for calling Louvain#2777

Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-22.12from
ChuckHastings:remove_legacy_louvain
Oct 13, 2022
Merged

remove unused mechanism for calling Louvain#2777
rapids-bot[bot] merged 1 commit intorapidsai:branch-22.12from
ChuckHastings:remove_legacy_louvain

Conversation

@ChuckHastings
Copy link
Collaborator

Closes #2495

Removes the call_louvain mechanism from cython.cu, it is no longer used.

@ChuckHastings ChuckHastings requested a review from a team as a code owner October 5, 2022 18:21
@ChuckHastings ChuckHastings self-assigned this Oct 5, 2022
@ChuckHastings ChuckHastings added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 5, 2022
@ChuckHastings ChuckHastings added this to the 22.12 milestone Oct 5, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.12@de0a714). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.12    #2777   +/-   ##
===============================================
  Coverage                ?   59.74%           
===============================================
  Files                   ?      111           
  Lines                   ?     6436           
  Branches                ?        0           
===============================================
  Hits                    ?     3845           
  Misses                  ?     2591           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 64ddc95 into rapidsai:branch-22.12 Oct 13, 2022
@ChuckHastings ChuckHastings deleted the remove_legacy_louvain branch December 2, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MNMG Louvain - Remove from cython.cu

3 participants