Code cleanup (remove dead code and move legacy files to the legacy directory)#2798
Conversation
|
Some of these changes are probably premature. Legacy jaccard/overlap is still in use by python. We also don't have an implementation for the weighted variation. |
I wonder why compile didn't fail in my local system. Aren't we calling these in cython/c_api? |
|
It seems like |
|
There was, before |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #2798 +/- ##
===============================================
Coverage ? 60.44%
===============================================
Files ? 111
Lines ? 6515
Branches ? 0
===============================================
Hits ? 3938
Misses ? 2577
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
rerun tests reason: test timeout, try rerunning for now but may have to look into it if it persists. |
|
rerun tests |
|
@gpucibot merge |
Code clean-up before bringing bigger changes to the codebase.
Breaking because several replaced legacy functions are deleted (I guess no one is directly using them).