Skip to content

Adds setup.py files and conda recipes for cugraph-service#2862

Merged
rapids-bot[bot] merged 28 commits intorapidsai:branch-22.12from
BradReesWork:branch-22.12-gass-conda
Nov 11, 2022
Merged

Adds setup.py files and conda recipes for cugraph-service#2862
rapids-bot[bot] merged 28 commits intorapidsai:branch-22.12from
BradReesWork:branch-22.12-gass-conda

Conversation

@BradReesWork
Copy link
Member

@BradReesWork BradReesWork commented Oct 28, 2022

Closes rapidsai/GaaS#20
Closes rapidsai/GaaS#19

For cugraph-service

  • Adding python setup
  • Adding build options to the build.sh script
  • creating the build to conda packages

@BradReesWork BradReesWork added feature request New feature or request non-breaking Non-breaking change labels Oct 28, 2022
@BradReesWork BradReesWork added this to the 22.12 milestone Oct 28, 2022
@BradReesWork BradReesWork requested review from a team as code owners October 28, 2022 13:21
@BradReesWork BradReesWork marked this pull request as draft October 28, 2022 13:21
@rlratzel rlratzel removed the request for review from a team October 31, 2022 02:14
@BradReesWork BradReesWork marked this pull request as ready for review November 1, 2022 15:13
@rlratzel rlratzel changed the title [skip-ci] [WIP] adding conda and setup build for cugraph-service Adds conda and setup build for cugraph-service Nov 4, 2022
@rlratzel rlratzel changed the title Adds conda and setup build for cugraph-service Adds setup.py files and conda recipes for cugraph-service Nov 4, 2022
…to build cugraph_service packages as part of cpu build script, added lines to upload new cugraph_service conda packages, fixed missing fi in build.sh, removed tabs in recipe, updated dependencies in recipe and setup.py
@rlratzel rlratzel marked this pull request as draft November 4, 2022 05:07
@BradReesWork BradReesWork marked this pull request as ready for review November 4, 2022 18:27
@BradReesWork
Copy link
Member Author

rerun tests

…rounds so split packages do not attempt to pip install runtime deps at build time, renamed top-level cugraph_service dir to be consistent with the package "cugraph-service" name
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.12@ffa4a6d). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head de33df8 differs from pull request most recent head f6191f4. Consider uploading reports for the commit f6191f4 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.12    #2862   +/-   ##
===============================================
  Coverage                ?   60.72%           
===============================================
  Files                   ?      122           
  Lines                   ?     6880           
  Branches                ?        0           
===============================================
  Hits                    ?     4178           
  Misses                  ?     2702           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BradReesWork
Copy link
Member Author

rerun tests

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving my own work here because this needs a python-codeowner and Brad can't approve since it started as his PR. I'll merge after this gets another approval.

@rlratzel rlratzel self-assigned this Nov 11, 2022
@rlratzel
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 79f86ab into rapidsai:branch-22.12 Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request New feature or request non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add separate client and server conda packages Add setup.py for cugraph_service_client and cugraph_service_server

5 participants