PyG Monorepo Refactor#2905
Merged
rapids-bot[bot] merged 127 commits intorapidsai:branch-22.12from Nov 30, 2022
Merged
Conversation
Currently, this only does SG version for rapidsai#2401. MG is still TODO. This also doesn't change anything user-facing (yet).
This includes a slow workaround for rapidsai/cudf#11550
…nto cgs-remote-wrappers
…to cgs-remote-wrappers
…to cgs-remote-sample
…to cgs-remote-sample
Co-authored-by: Vibhu Jawa <vibhujawa@gmail.com>
BradReesWork
requested changes
Nov 21, 2022
VibhuJawa
suggested changes
Nov 22, 2022
Member
VibhuJawa
left a comment
VibhuJawa
left a comment
There was a problem hiding this comment.
Minor cleanup requested on setup.py, looks good otherwise. Thanks again for addressing the last reviews.
Co-authored-by: Vibhu Jawa <vibhujawa@gmail.com>
Co-authored-by: Vibhu Jawa <vibhujawa@gmail.com>
VibhuJawa
approved these changes
Nov 22, 2022
Member
VibhuJawa
left a comment
VibhuJawa
left a comment
There was a problem hiding this comment.
Thanks for addressing the changes, LGTM
rlratzel
approved these changes
Nov 28, 2022
…to pyg-monorepo-refactor
…to pyg-monorepo-refactor
BradReesWork
approved these changes
Nov 29, 2022
Member
Author
|
rerun tests |
Member
|
@gpucibot merge |
rlratzel
requested changes
Nov 30, 2022
Contributor
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
Looks like a typo is causing at least one of the error messages in CI.
Co-authored-by: Rick Ratzel <3039903+rlratzel@users.noreply.github.com>
rlratzel
approved these changes
Nov 30, 2022
nv-rliu
pushed a commit
to nv-rliu/cugraph-gnn
that referenced
this pull request
Jul 15, 2025
Moves the PyG extensions to their own package. Includes conda package configurations. - [x] File structure - [x] Enable CI - [x] Example integration test - [x] Double-check PyG dependency, conda channel Due to PyG 2.2 not being released on conda yet, it is not a hard dependency. This will be resolved when PyG 2.2 is released with conda packages. Going forward, we should encourage PyG to make their nightly builds available on conda so this issue does not occur again. Resolves rapidsai/graph_dl#48 Resolves rapidsai/graph_dl#93 Authors: - Alex Barghi (https://github.com/alexbarghi-nv) - Erik Welch (https://github.com/eriknw) Approvers: - Vibhu Jawa (https://github.com/VibhuJawa) - Rick Ratzel (https://github.com/rlratzel) - Brad Rees (https://github.com/BradReesWork) - Mark Sadang (https://github.com/msadang) URL: rapidsai/cugraph#2905
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the PyG extensions to their own package. Includes conda package configurations.
Due to PyG 2.2 not being released on conda yet, it is not a hard dependency. This will be resolved when PyG 2.2 is released with conda packages. Going forward, we should encourage PyG to make their nightly builds available on conda so this issue does not occur again.
Resolves https://github.com/rapidsai/graph_dl/issues/48
Resolves https://github.com/rapidsai/graph_dl/issues/93