Skip to content

Implement C API Similarity#2923

Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-22.12from
ChuckHastings:implement_c_api_similarity
Nov 15, 2022
Merged

Implement C API Similarity#2923
rapids-bot[bot] merged 3 commits intorapidsai:branch-22.12from
ChuckHastings:implement_c_api_similarity

Conversation

@ChuckHastings
Copy link
Collaborator

Joseph discovered that the C API hadn't been implemented for the similarity algorithms (it was partially implemented and disabled). This PR addresses that.

@ChuckHastings ChuckHastings requested a review from a team as a code owner November 15, 2022 01:15
@ChuckHastings ChuckHastings self-assigned this Nov 15, 2022
@ChuckHastings ChuckHastings added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 15, 2022
@ChuckHastings ChuckHastings added this to the 22.12 milestone Nov 15, 2022
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 403ee20 into rapidsai:branch-22.12 Nov 15, 2022
@ChuckHastings ChuckHastings deleted the implement_c_api_similarity branch December 2, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants