[REVIEW] Graph sage example#2925
Merged
rapids-bot[bot] merged 34 commits intorapidsai:branch-23.04from Mar 28, 2023
Merged
Conversation
VibhuJawa
added
improvement
BradReesWork
requested review from
alexbarghi-nv,
tingyu66 and
wangxiaoyunNV
tingyu66
requested changes
Nov 17, 2022
Member
There was a problem hiding this comment.
Looks good. Just have the following comments:
I don't think we need to supportmodeother thancugraph_storage, and the code have assumed to use cugraph_storage in a few places, indicated by callinggraph.get_node_storage()- Need more explanation around the batch_size and the rmm option to users.
wangxiaoyunNV
approved these changes
Nov 18, 2022
Contributor
wangxiaoyunNV
left a comment
wangxiaoyunNV
left a comment
There was a problem hiding this comment.
see my comments in the code
wangxiaoyunNV
requested changes
Nov 18, 2022
Contributor
wangxiaoyunNV
left a comment
wangxiaoyunNV
left a comment
There was a problem hiding this comment.
Please see me comments in the code.
alexbarghi-nv
previously approved these changes
Nov 21, 2022
Member
alexbarghi-nv
left a comment
alexbarghi-nv
left a comment
There was a problem hiding this comment.
Looks like Xiaoyun addressed everything that needed additional review. Approved.
BradReesWork
dismissed stale reviews from wangxiaoyunNV, tingyu66, and alexbarghi-nv
The base branch was changed.
|
@VibhuJawa any status updates? |
Member
Author
Yeah, we finally have approval to merge this in now :-D . Will update this PR |
rlratzel
requested changes
Mar 10, 2023
Contributor
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
LGTM, just a couple of minor comments
Member
Author
|
@rlratzel , All your reviews have been addressed. |
rlratzel
approved these changes
Mar 28, 2023
Member
Author
|
@tingyu66 , @alexbarghi-nv Waiting on you all's approval too. |
Member
|
/merge |
nv-rliu
pushed a commit
to nv-rliu/cugraph-gnn
that referenced
this pull request
Jul 15, 2025
This PR closes #2968 Verified that we work on rapidsai/cugraph#2925 Authors: - Vibhu Jawa (https://github.com/VibhuJawa) - Rick Ratzel (https://github.com/rlratzel) Approvers: - Rick Ratzel (https://github.com/rlratzel) URL: rapidsai/cugraph#3000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends upon #2924 .
We add
Graph-Sageexample to claimdgl,cugraphintegration.Waiting on SWIPAT before merging
CC: @TristonC