Skip to content

Updates conda versioning to install correct dependencies, changes CI script to better track deps from individual build installs#3066

Merged
rapids-bot[bot] merged 9 commits intorapidsai:branch-23.02from
seunghwak:ci_experiment
Dec 14, 2022
Merged

Updates conda versioning to install correct dependencies, changes CI script to better track deps from individual build installs#3066
rapids-bot[bot] merged 9 commits intorapidsai:branch-23.02from
seunghwak:ci_experiment

Conversation

@seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Dec 8, 2022

  • Updates versioning in conda recipes so the correct dependencies are installed, specifically UCX-Py and CTK. These were causing CI to fall back to installs from the nightly channel instead of the packages built from the PR sources, since the older nightlies were the only ones compatible. This also resulted in the wrong CTK version to be installed in some cases.
  • Changes CI script to install each built package individually so log output shows the deps installed for each one. If all packages are installed in one install line, developers debugging CI can't tell which packages caused certain dependencies to be installed.

@seunghwak seunghwak requested a review from a team as a code owner December 8, 2022 20:12
@seunghwak seunghwak added 3 - Ready for Review improvement Improvement / enhancement to an existing function DO NOT MERGE Hold off on merging; see PR for details non-breaking Non-breaking change and removed DO NOT MERGE Hold off on merging; see PR for details labels Dec 8, 2022
@seunghwak seunghwak changed the title CI experiment [DO-NOT-MERGE] CI experiment Dec 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.02@efcf6a8). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.02    #3066   +/-   ##
===============================================
  Coverage                ?   58.79%           
===============================================
  Files                   ?      131           
  Lines                   ?     7864           
  Branches                ?        0           
===============================================
  Hits                    ?     4624           
  Misses                  ?     3240           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChuckHastings
Copy link
Collaborator

rerun tests

@rlratzel rlratzel requested a review from a team as a code owner December 9, 2022 23:21
@ajschmidt8
Copy link
Member

@seunghwak, the message below also applies to DO NOT MERGE PRs.


Please use GitHub's Draft PR feature instead of WIP tags in the future. Draft PRs have the benefit of preventing notifications to codeowners until PRs are marked Ready for Review, which helps cut down on excessive notifications for PRs that are still being worked on. CI will still run on Draft PRs.

Some useful information about Draft PRs:

@ajschmidt8 ajschmidt8 marked this pull request as draft December 12, 2022 17:52
@rlratzel rlratzel changed the title [DO-NOT-MERGE] CI experiment Updates conda versioning to use correct CUDA version, changes CI script to better track deps from individual build installs Dec 13, 2022
@rlratzel rlratzel changed the title Updates conda versioning to use correct CUDA version, changes CI script to better track deps from individual build installs Updates conda versioning to install correct dependencies, changes CI script to better track deps from individual build installs Dec 13, 2022
@rlratzel rlratzel marked this pull request as ready for review December 14, 2022 02:29
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also helps clarify some questions I had for the transition to GitHub Actions. My approval has no power but I think this looks good.

@rlratzel rlratzel removed the request for review from a team December 14, 2022 04:34
@rlratzel
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 017f0cc into rapidsai:branch-23.02 Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants