[REVIEW] Add cugraph+UCX build instructions#3088
Merged
rapids-bot[bot] merged 11 commits intorapidsai:branch-23.02from Jan 4, 2023
Merged
[REVIEW] Add cugraph+UCX build instructions#3088rapids-bot[bot] merged 11 commits intorapidsai:branch-23.02from
rapids-bot[bot] merged 11 commits intorapidsai:branch-23.02from
Conversation
BradReesWork
approved these changes
Dec 19, 2022
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This reverts commit 2f99d6e.
alexbarghi-nv
approved these changes
Jan 3, 2023
rlratzel
approved these changes
Jan 3, 2023
Contributor
rlratzel
left a comment
There was a problem hiding this comment.
LGTM. I do have a question and a suggestion but I'll also approve as-is.
Codecov ReportBase: 58.86% // Head: 57.14% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #3088 +/- ##
================================================
- Coverage 58.86% 57.14% -1.72%
================================================
Files 131 148 +17
Lines 7848 9302 +1454
================================================
+ Hits 4620 5316 +696
- Misses 3228 3986 +758
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Member
Author
|
@rlratzel , Addressed your reviews, please merge if this is good to merge. |
Contributor
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the instructions to build cugraph+UCX for benchmarking .
The current conda build does not support IB as well has challenges using NVLINK . This PR adds the dockefile as well as build instructions and test to streamline benchmarking effort.
The expected speedup on sampling is around
8xby using the UCX souce build and a20xbetter bandwidth with compute.See README for instructions .
Benchmarks
dask.computebandwidthWith the standard conda build :
With this PRs Build :
cugraph samplingbenchmarkWith the standard conda build :
With this PRs Build :