GH Actions Notebook Testing Fixes#3097
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-23.02from Jan 1, 2023
Merged
GH Actions Notebook Testing Fixes#3097rapids-bot[bot] merged 2 commits intorapidsai:branch-23.02from
rapids-bot[bot] merged 2 commits intorapidsai:branch-23.02from
Conversation
Member
Author
|
cc: @bdice |
Codecov ReportBase: 58.86% // Head: 57.18% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #3097 +/- ##
================================================
- Coverage 58.86% 57.18% -1.68%
================================================
Files 131 148 +17
Lines 7848 9292 +1444
================================================
+ Hits 4620 5314 +694
- Misses 3228 3978 +750
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bdice
approved these changes
Dec 31, 2022
Member
Author
|
@gpucibot merge |
Member
Author
FWIW, I opened a PR below to add a job to test this automatically since it's easy to forget. It works locally, just need to test it in a PR before we merge it. |
raydouglass
approved these changes
Jan 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains fixes for some things I missed in #3095.
Specifically:
conda-notebook-testsjob as a dependency of thepr-builderjobnotebookdependency fromdependencies.yaml