Drop DiGraph#3126
Merged
rapids-bot[bot] merged 19 commits intorapidsai:branch-23.02from Jan 12, 2023
BradReesWork:2302-cleanup
Merged
Drop DiGraph#3126rapids-bot[bot] merged 19 commits intorapidsai:branch-23.02from BradReesWork:2302-cleanup
rapids-bot[bot] merged 19 commits intorapidsai:branch-23.02from
BradReesWork:2302-cleanup
Conversation
BradReesWork
added
improvement
alexbarghi-nv
requested changes
Jan 10, 2023
Member
alexbarghi-nv
left a comment
alexbarghi-nv
left a comment
There was a problem hiding this comment.
looks good, just minor changes requested and one question
acostadon
reviewed
Jan 10, 2023
Co-authored-by: Alex Barghi <105237337+alexbarghi-nv@users.noreply.github.com>
Co-authored-by: Alex Barghi <105237337+alexbarghi-nv@users.noreply.github.com>
Co-authored-by: Alex Barghi <105237337+alexbarghi-nv@users.noreply.github.com>
Co-authored-by: Alex Barghi <105237337+alexbarghi-nv@users.noreply.github.com>
Co-authored-by: Alex Barghi <105237337+alexbarghi-nv@users.noreply.github.com>
Co-authored-by: Alex Barghi <105237337+alexbarghi-nv@users.noreply.github.com>
Co-authored-by: Alex Barghi <105237337+alexbarghi-nv@users.noreply.github.com>
Co-authored-by: Alex Barghi <105237337+alexbarghi-nv@users.noreply.github.com>
Member
|
/merge |
…into 2302-cleanup
24 tasks
Member
Author
|
rerun tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR removes the DiGraph classes and all references to those classes from the code and tests.
All test are updated and validated.
DiGraph has been deprecated for over a year and it was time to finally remove it
closes #3136