Skip to content

Created notebook for running louvain algorithm on a Multi-GPU Property Graph#3130

Merged
rapids-bot[bot] merged 14 commits intorapidsai:branch-23.02from
acostadon:mg_nb_1230
Jan 31, 2023
Merged

Created notebook for running louvain algorithm on a Multi-GPU Property Graph#3130
rapids-bot[bot] merged 14 commits intorapidsai:branch-23.02from
acostadon:mg_nb_1230

Conversation

@acostadon
Copy link
Contributor

resolves #2609
This notebook specifically creates a multi-GPU Property graph. Might need to create a single-GPU later but this shows
use of the Property Graph interface.

Also updated the mg_louvain notebook to function with change to Comms.

@acostadon acostadon requested a review from a team as a code owner January 11, 2023 12:29
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@acostadon acostadon self-assigned this Jan 11, 2023
@acostadon acostadon added feature request New feature or request non-breaking Non-breaking change Fix labels Jan 11, 2023
@acostadon acostadon changed the title Created notebook for running a louvain on a Multi-GPU Property Graph Created notebook for running louvain algorithm on a Multi-GPU Property Graph Jan 11, 2023
@BradReesWork BradReesWork added this to the 23.02 milestone Jan 23, 2023
@BradReesWork
Copy link
Member

Header should include the update block

Copy link
Member

@BradReesWork BradReesWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor header update

Copy link

@kingmesal kingmesal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree w/ Rick's suggestions. Looks pretty solid overall.

@BradReesWork
Copy link
Member

I would suggest that a better notebook would be to

  • Show how to create a PG from multiple sources (or generate a collection of features to add)
  • show how the PG can be used to induce a subgraph based on features
    PG offers the user access to more that just vertex and edge IDs. That needs to be highlighted

Start by making a SG version, then move to MG

@BradReesWork BradReesWork requested a review from rlratzel January 31, 2023 14:41
@codecov-commenter
Copy link

Codecov Report

Base: 55.28% // Head: 55.28% // No change to project coverage 👍

Coverage data is based on head (38ace90) compared to base (9754157).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-23.02    #3130   +/-   ##
=============================================
  Coverage         55.28%   55.28%           
=============================================
  Files               148      148           
  Lines              9576     9576           
=============================================
  Hits               5294     5294           
  Misses             4282     4282           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 9edc8f7 into rapidsai:branch-23.02 Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request New feature or request non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] Notebook on Property Graph

5 participants