Initial implementation of the Leiden C API#3165
Merged
rapids-bot[bot] merged 6 commits intorapidsai:branch-23.04from Mar 16, 2023
Merged
Initial implementation of the Leiden C API#3165rapids-bot[bot] merged 6 commits intorapidsai:branch-23.04from
rapids-bot[bot] merged 6 commits intorapidsai:branch-23.04from
Conversation
ChuckHastings
added
3 - Ready for Review
improvement
rlratzel
approved these changes
Mar 9, 2023
naimnv
approved these changes
Mar 10, 2023
jnke2016
reviewed
Mar 13, 2023
| * fewer larger communities. | ||
| * @param [in] do_expensive_check | ||
| * A flag to run expensive checks for input arguments (if set to true) | ||
| * @param [out] result Output from the Louvain call |
Contributor
There was a problem hiding this comment.
typo. I think you meant Leiden
seunghwak
approved these changes
Mar 16, 2023
Contributor
seunghwak
left a comment
seunghwak
left a comment
There was a problem hiding this comment.
LGTM (except for few minor cosmetic issues)
| vertex_t h_result[] = {0, 1, 0, 1, 1, 1}; | ||
| weight_t expected_modularity = 0.218166; | ||
|
|
||
| // Louvain wants store_transposed = FALSE |
| @@ -0,0 +1,139 @@ | |||
| /* | |||
| * Copyright (c) 2022, NVIDIA CORPORATION. | |||
| 0.1f, 2.1f, 1.1f, 5.1f, 3.1f, 4.1f, 7.2f, 3.2f, 0.1f, 2.1f, 1.1f, 5.1f, 3.1f, 4.1f, 7.2f, 3.2f}; | ||
| vertex_t h_result[] = {1, 0, 1, 0, 0, 0}; | ||
|
|
||
| // Louvain wants store_transposed = FALSE |
Collaborator
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR defines the C API for Leiden - which should look the same as Louvain.
The implementation (calls to C++ Leiden implementation) are ifdef'ed out. Once #2980 is merged we can provide the actual call here.
Closes #2483
Closes #2486