Remove gpuCI scripts.#3242
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.04 #3242 +/- ##
===============================================
Coverage ? 56.26%
===============================================
Files ? 153
Lines ? 9658
Branches ? 0
===============================================
Hits ? 5434
Misses ? 4224
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
|
||
| Note: This conda installation only applies to Linux and Python versions 3.8/3.10. | ||
|
|
||
| ### Building and Testing on a gpuCI image locally |
There was a problem hiding this comment.
Should we provide updated instructions on this? With the new GA approach, there are new scripts that provide this behavior. Is there documentation somewhere that describes how one would run the process that mimics CI that we could link to here?
There was a problem hiding this comment.
You're ahead of the curve, @ChuckHastings.
I still have to get that new functionality properly documented somewhere.
I'll try to get to it this week.
There was a problem hiding this comment.
One of my life curses :-). Always a challenge when you live ahead of the curve.
There was a problem hiding this comment.
Opened a PR for these new docs below.
There was a problem hiding this comment.
@ChuckHastings, with that new documentation almost published, would you mind approving this PR so we can get this merged?
ajschmidt8
left a comment
ajschmidt8
left a comment
There was a problem hiding this comment.
I can't add a code suggestion for this, but we should also remove any preserve_egg_dir: True lines from the conda recipes.
These were added back with the setuptools pin in an attempt to resolve a Jenkins-image related conda issue.
It seems like it was copied and pasted to multiple new recipes.
This line was added a while back in an attempt to resolve an issue that only occurred with our old CI images that were used in Jenkins. It can be safely removed now that `cugraph` is on GHAs with new CI images.
ajschmidt8
added
improvement
|
/merge |
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
LGTM.
This could be more of a suggestion for a separate PR, but can we add documentation somewhere on how to run the CI style checks locally, since the unofficial/undocumented suggestion before was to simply run the now-removed style.sh script? I believe there may be docs somewhere on how to install the pre-commit hooks somewhere, but I can't find it, and having it in CONTRIBUTING or SOURCEBUILD or something would be great.
@rlratzel Feel free to use this section of the cuDF contributing guide as a model: https://github.com/rapidsai/cudf/blob/branch-23.04/CONTRIBUTING.md#code-formatting |
5 participants
Since migrating to GitHub Actions, the gpuCI scripts are no longer needed. This PR removes those outdated gpuCI scripts.