Skip to content

Add missing cugraph-ops conditional#3270

Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-23.04from
vyasr:fix/build_issues
Feb 27, 2023
Merged

Add missing cugraph-ops conditional#3270
rapids-bot[bot] merged 3 commits intorapidsai:branch-23.04from
vyasr:fix/build_issues

Conversation

@vyasr
Copy link
Contributor

@vyasr vyasr commented Feb 14, 2023

This change is necessary for compilation with USE_CUGRAPH_OPS=OFF.

@vyasr vyasr added bug Something isn't working non-breaking Non-breaking change labels Feb 14, 2023
@vyasr vyasr self-assigned this Feb 14, 2023
@vyasr
Copy link
Contributor Author

vyasr commented Feb 14, 2023

After this change I'm still seeing an error /home/vyasr/local/rapids/cugraph/cpp/tests/sampling/sg_uniform_neighbor_sampling.cu (144): error: no instance of function template "cugraph::uniform_neighbor_sample" matches the argument list locally. That doesn't seem related to cugraph-ops at all, but perhaps some test needs to be updated in some way for another reason.

@ChuckHastings
Copy link
Collaborator

After this change I'm still seeing an error /home/vyasr/local/rapids/cugraph/cpp/tests/sampling/sg_uniform_neighbor_sampling.cu (144): error: no instance of function template "cugraph::uniform_neighbor_sample" matches the argument list locally. That doesn't seem related to cugraph-ops at all, but perhaps some test needs to be updated in some way for another reason.

That is likely unrelated. Are you sure this is a clean build from source? The cugraph::uniform_neighbor_sample function signature was recently changed. If you are somehow picking up an older version of the header file you might see this error. The compilation in CI seems to be succeeding.

@vyasr
Copy link
Contributor Author

vyasr commented Feb 14, 2023

Hmm I'm not sure what is happening locally that's causing this issue. I have cleaned the build but I'm still seeing the error. In any case, since this works in CI and I'm not doing active cugraph work other than verifying that builds are working after the spdlog/fmt update in rmm, I'm fine pushing this change out now.

@vyasr vyasr marked this pull request as ready for review February 14, 2023 20:08
@vyasr vyasr requested a review from a team as a code owner February 14, 2023 20:08
@vyasr vyasr changed the title Add missing cugraph-ops conditional. Add missing cugraph-ops conditional Feb 16, 2023
@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit 08ae65a into rapidsai:branch-23.04 Feb 27, 2023
@vyasr vyasr deleted the fix/build_issues branch February 27, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants