Skip to content

Refactoring tests#3292

Merged
rapids-bot[bot] merged 31 commits intorapidsai:branch-23.04from
BradReesWork:branch_2304_test_refactor
Mar 10, 2023
Merged

Refactoring tests#3292
rapids-bot[bot] merged 31 commits intorapidsai:branch-23.04from
BradReesWork:branch_2304_test_refactor

Conversation

@BradReesWork
Copy link
Member

@BradReesWork BradReesWork commented Feb 17, 2023

Redoing the organization of the python tests.

Merging both SG and MG together and using tag to specify runs
organizing tests by graph function

MG Test File Renaming

  • MG test files now end with "_mg" rather than starting with "test_mg". This will make it easier to see that there are test pairs, SG and MG, since a listing will now group files together.

mg pytest marker

  • created a pytest marker called "mg" to identify MG test and allow CI/users to either include or skip
  • pytest -m mg to run all mg tests
  • pytest -m "not mg" to skip all MG tests

sg marker
test only SG code
pytest -m sg

Added markers for "sg" and "ci" for future use
Fixed a number of test issues

closes #1481

@BradReesWork BradReesWork added the improvement Improvement / enhancement to an existing function label Feb 17, 2023
@BradReesWork BradReesWork added the non-breaking Non-breaking change label Feb 28, 2023
@BradReesWork BradReesWork changed the title [skip-ci] Refactoring tests Refactoring tests Feb 28, 2023
@BradReesWork BradReesWork marked this pull request as ready for review February 28, 2023 16:58
@BradReesWork BradReesWork requested review from a team as code owners February 28, 2023 16:58
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just found the one double paste. Otherwise looked good to me.

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for tackling this one. I have a few very minor feedback items.

Also, I think I prefer explicitly marking the tests like you did here, but FWIW for anyone else reading this, one can also apply a marker to an entire file of tests by using a pytestmark variable, like this.

@rlratzel
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit c8a5ea8 into rapidsai:branch-23.04 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] Re-org python test directory for consistency and ease-of-use

5 participants