Refactoring tests#3292
Merged
rapids-bot[bot] merged 31 commits intorapidsai:branch-23.04from Mar 10, 2023
BradReesWork:branch_2304_test_refactor
Merged
Refactoring tests#3292rapids-bot[bot] merged 31 commits intorapidsai:branch-23.04from BradReesWork:branch_2304_test_refactor
rapids-bot[bot] merged 31 commits intorapidsai:branch-23.04from
BradReesWork:branch_2304_test_refactor
Conversation
acostadon
reviewed
Feb 28, 2023
raydouglass
approved these changes
Feb 28, 2023
acostadon
approved these changes
Feb 28, 2023
Contributor
acostadon
left a comment
There was a problem hiding this comment.
just found the one double paste. Otherwise looked good to me.
…esWork/cugraph into branch_2304_test_refactor
rlratzel
requested changes
Mar 9, 2023
Contributor
rlratzel
left a comment
There was a problem hiding this comment.
Looks good, thanks for tackling this one. I have a few very minor feedback items.
Also, I think I prefer explicitly marking the tests like you did here, but FWIW for anyone else reading this, one can also apply a marker to an entire file of tests by using a pytestmark variable, like this.
python/cugraph/cugraph/tests/centrality/test_batch_betweenness_centrality_mg.py
Outdated
Show resolved
Hide resolved
python/cugraph/cugraph/tests/link_prediction/test_overlap_mg.py
Outdated
Show resolved
Hide resolved
rlratzel
approved these changes
Mar 9, 2023
jnke2016
approved these changes
Mar 9, 2023
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redoing the organization of the python tests.
Merging both SG and MG together and using tag to specify runs
organizing tests by graph function
MG Test File Renaming
mg pytest marker
pytest -m mgto run all mg testspytest -m "not mg"to skip all MG testssg marker
test only SG code
pytest -m sg
Added markers for "sg" and "ci" for future use
Fixed a number of test issues
closes #1481