Properly handle dask change#3361
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-23.04from Mar 24, 2023
Merged
Conversation
alexbarghi-nv
added
bug
alexbarghi-nv
approved these changes
Mar 24, 2023
Member
alexbarghi-nv
left a comment
alexbarghi-nv
left a comment
There was a problem hiding this comment.
Looks fine to me, will also need ops approval.
ajschmidt8
approved these changes
Mar 24, 2023
Member
ajschmidt8
left a comment
ajschmidt8
left a comment
There was a problem hiding this comment.
approved.
thanks for removing the raft changes.
they shouldn't have been merged.
i left a comment about it here: https://github.com/rapidsai/cugraph/pull/3348/files#r1147661079
Member
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
A Dask PR which was merged last week changed the way workers are retrieved from client calls. This [PR](#3361) assumed that the worker could be retrieve through `get_client()` and since the Dask version was pinned in RAFT to no break CI, it temporarily worked. But after the `dask `version was unpinned, this resulted in the issue this PR is closing. This PR leverages the `dask_worker` input argument which is populated with the worker when calling `client.run`. closes #3378 Authors: - Joseph Nke (https://github.com/jnke2016) Approvers: - Rick Ratzel (https://github.com/rlratzel) - Brad Rees (https://github.com/BradReesWork) URL: #3379
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
daskbreaking change updates the way a worker is passed into the distributed function causing all the MG tests to fail.This PR properly handles the change and also removes the temporary raft PR pinned in the
cishell script.