Sphinx updates#3468
Merged
rapids-bot[bot] merged 12 commits intorapidsai:branch-23.06from Apr 13, 2023
BradReesWork:fixing_sphinx_errors
Merged
Sphinx updates#3468rapids-bot[bot] merged 12 commits intorapidsai:branch-23.06from BradReesWork:fixing_sphinx_errors
rapids-bot[bot] merged 12 commits intorapidsai:branch-23.06from
BradReesWork:fixing_sphinx_errors
Conversation
Member
|
@BradReesWork, in other repositories that didn't have a lot of sphinx warnings, we used the It's probably worth adding that to |
Member
Author
|
@ajschmidt8 I do use the "-W" flag when I'm debugging. There are still a large number of improvements that need to be finished before the code is ready for that flag - but by the end of this release it should be turned on |
ajschmidt8
approved these changes
Apr 13, 2023
rlratzel
approved these changes
Apr 13, 2023
Contributor
rlratzel
left a comment
There was a problem hiding this comment.
Looks good. I'm approving and this can be merged, but I do have a question which could result in a change based on what you think.
Contributor
|
/merge |
| >>> | ||
| >>> distances, predecessors, vertices = res | ||
| >>> | ||
| f>>> inal_results = cudf.DataFrame({ |
Contributor
There was a problem hiding this comment.
Typo?
>>> final_results = cudf.DataFrame({
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spinx is very picky and looks for indentations and black lines. Also during the build, if there is an error, Spinx just ignores the function that caused the error rather to terminating the build.
Some docstrings also used reserved character {* and _} which are used for formating
This PR:
You will see a lot of additional blank lines added and some text clean-up for readability.
Seems like the PR also picked up all the the 23.06 updates - so half the files are not really for this PR