Changes to support gtest version 1.11#3511
Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-23.06from May 1, 2023
Merged
Changes to support gtest version 1.11#3511rapids-bot[bot] merged 4 commits intorapidsai:branch-23.06from
rapids-bot[bot] merged 4 commits intorapidsai:branch-23.06from
Conversation
ChuckHastings
added
improvement
naimnv
approved these changes
Apr 26, 2023
seunghwak
reviewed
Apr 26, 2023
|
|
||
| #if 0 | ||
| // FIXME: We should use these tests, gtest-1.11.0 makes it a runtime error | ||
| // to define and not instantiate these. |
Contributor
There was a problem hiding this comment.
Shouldn't we better run this? Or is this test failing?
Collaborator
Author
There was a problem hiding this comment.
There is no current RMAT test defined below. We create the definition here, but we aren't actually using it below.
gtest 1.10 (which we are currently using) ignored this.
gtest 1.11 (which is used by DLFW and I assume we will migrate to shortly) treats the definition of a TEST_P and not using it as an error.
This is the expedient solution (ifdef out the offending definitions that aren't used). I added the FIXME to identify that we should actually be using these tests. But I needed a simple fix to unblock DLFW and didn't want to spend the time to add and debug the Rmat tests for these algorithms.
seunghwak
approved these changes
May 1, 2023
Collaborator
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gtest version 1.11 adds a feature that complains if we define a test but do not instantiate it. We have a few cases where we define a case, but we don't instantiate it at the moment. This PR will ifdef these out so that they will run properly.
Also shrunk the size of an MG rmat test so that it would fit in a 1 GPU test.