[IMP] Match Default PyG Hop ID Behavior in cuGraph-PyG#3565
Merged
rapids-bot[bot] merged 22 commits intorapidsai:branch-23.06from May 22, 2023
Merged
[IMP] Match Default PyG Hop ID Behavior in cuGraph-PyG#3565rapids-bot[bot] merged 22 commits intorapidsai:branch-23.06from
rapids-bot[bot] merged 22 commits intorapidsai:branch-23.06from
Conversation
…to cugraph-pyg-hops
alexbarghi-nv
added
improvement
rlratzel
approved these changes
May 19, 2023
|
|
||
| index = cugraph_store._get_vertex_groups_from_sample(nodes_of_interest) | ||
| assert index["vt1"].tolist() == sorted(nodes_of_interest.tolist()) | ||
| assert index["vt1"].tolist() == nodes_of_interest.tolist() |
Contributor
There was a problem hiding this comment.
No suggestion here, but I'm curious why sorted() was removed (or why it wasn't added to both lists being compared), since wouldn't that be a more reliable compare? Or, does order matter?
Member
Author
There was a problem hiding this comment.
Order does matter now, that is one of the changes in this PR. Before, the nodes of interest were sorted, but that is not correct - they should be returned in order of appearance.
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3563
Closes #3564
Merge after #3567