[BUG] Skip Empty Partitions in Bulk Sample Writing#3600
Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-23.06from May 24, 2023
Merged
Conversation
alexbarghi-nv
added
bug
VibhuJawa
approved these changes
May 23, 2023
Member
VibhuJawa
left a comment
VibhuJawa
left a comment
There was a problem hiding this comment.
LGTM. Thanks for triaging this @alexbarghi-nv
BradReesWork
approved these changes
May 24, 2023
Member
Author
|
/merge |
nv-rliu
pushed a commit
to nv-rliu/cugraph-gnn
that referenced
this pull request
Jul 15, 2025
Currently, when the bulk sampler writes its samples, it does not check whether the partition is empty. This causes all of the empty partitions to collide and attempt to write to the same (empty) file at once. This writing should not occur at all. This PR adds a check that skips writing if the partition is empty. This should resolve the nightly test failures. Authors: - Alex Barghi (https://github.com/alexbarghi-nv) Approvers: - Vibhu Jawa (https://github.com/VibhuJawa) - Brad Rees (https://github.com/BradReesWork) URL: rapidsai/cugraph#3600
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when the bulk sampler writes its samples, it does not check whether the partition is empty. This causes all of the empty partitions to collide and attempt to write to the same (empty) file at once. This writing should not occur at all.
This PR adds a check that skips writing if the partition is empty.
This should resolve the nightly test failures.