Skip to content

[BUG] Fix Calls to cudf.DataFrame/Series.unique that relied on old behavior#3616

Merged
rapids-bot[bot] merged 6 commits intorapidsai:branch-23.06from
alexbarghi-nv:fix-unique
May 27, 2023
Merged

[BUG] Fix Calls to cudf.DataFrame/Series.unique that relied on old behavior#3616
rapids-bot[bot] merged 6 commits intorapidsai:branch-23.06from
alexbarghi-nv:fix-unique

Conversation

@alexbarghi-nv
Copy link
Member

@alexbarghi-nv alexbarghi-nv commented May 25, 2023

Updates the code that relied on unique() to return values in sorted order by explicitly sorting the unique values.

Closes #3615

@alexbarghi-nv alexbarghi-nv self-assigned this May 25, 2023
@alexbarghi-nv alexbarghi-nv added bug Something isn't working non-breaking Non-breaking change labels May 25, 2023
@alexbarghi-nv alexbarghi-nv added this to the 23.06 milestone May 25, 2023
@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review May 25, 2023 20:56
@alexbarghi-nv alexbarghi-nv requested a review from a team as a code owner May 25, 2023 20:56
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 1e6da2b into rapidsai:branch-23.06 May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check and correct if necessary code broken from cudf unique and drop_duplicates behavior change

4 participants