[REVIEW] Add Pure DGL Dataloading benchmark#3660
Merged
rapids-bot[bot] merged 12 commits intorapidsai:branch-23.10from Sep 26, 2023
Merged
[REVIEW] Add Pure DGL Dataloading benchmark#3660rapids-bot[bot] merged 12 commits intorapidsai:branch-23.10from
rapids-bot[bot] merged 12 commits intorapidsai:branch-23.10from
Conversation
Member
Author
|
I would like to get a look from @tingyu66 here too |
tingyu66
approved these changes
Aug 21, 2023
Member
tingyu66
left a comment
There was a problem hiding this comment.
Looks good to me. If being nitpicking, I'd like to fix random seed (with dgl.seed() and torch.manual_seed()) for all benchmarks.
Member
Author
|
@tingyu66 , Added seed with commit: f99a518 @alexbarghi-nv , I think we should be good to merge. |
Member
Author
|
Just dropping updated numbers for awareness as we use this in comparisons. |
Member
|
/ok to test |
Member
|
/ok to test |
Member
|
/okay to test |
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the DGL data loading benchmark:
Arguments supported:
This produces the following results on a V100: