Refactor RMAT#3662
Merged
rapids-bot[bot] merged 66 commits intorapidsai:branch-23.08from Jul 25, 2023
Merged
Conversation
added 12 commits
June 21, 2023 08:51
added 7 commits
June 22, 2023 08:18
…ings and function calls
added 9 commits
July 11, 2023 05:10
rlratzel
requested changes
Jul 12, 2023
Contributor
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
Looks good, thanks, just a couple more requests.
ChuckHastings
approved these changes
Jul 18, 2023
rlratzel
approved these changes
Jul 25, 2023
Contributor
|
/merge |
This was referenced Jul 25, 2023
This was referenced Jul 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the RMAT generator, update docstrings and tests