Testing util improvements and refactoring#3705
Merged
rapids-bot[bot] merged 34 commits intorapidsai:branch-23.10from Aug 22, 2023
Merged
Testing util improvements and refactoring#3705rapids-bot[bot] merged 34 commits intorapidsai:branch-23.10from
rapids-bot[bot] merged 34 commits intorapidsai:branch-23.10from
Conversation
Merging 15 commits from Jul 18-24
Merge commits from 7/18 to 7/24 (18 total)
Merging commits from Aug 2-3
betochimas
force-pushed
the
branch-23.08-resultsset
branch
from
8114449 to
95685db
Compare
rlratzel
requested changes
Aug 11, 2023
Contributor
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
Starting to look good for a first pass. We'll eventually refactor quite a lot of the fixtures out on future PRs, but just replacing Nx calls initially is a good start.
We need to get the resultset data uploaded and the rest of the download/unpack code written to fully test end-to-end and get this passing CI.
betochimas
force-pushed
the
branch-23.08-resultsset
branch
from
e8d9a82 to
2a92f2f
Compare
rlratzel
reviewed
Aug 18, 2023
rlratzel
added
improvement
rlratzel
requested changes
Aug 21, 2023
Contributor
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
Looks good, just one small request.
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2416
Removes a dependency when running python tests, which will speed up test runs. Also introduces a new testing component (
Resultset) to clean up unit tests by generating golden results and storing them locally/on the cloud. This PR is focused on tests from thetraversalcategory.NOTE: Devs will download specific golden results from the cloud to avoid local overhead.