[BUG] Fix namesapce to default_hash and hash_functions#3711
Merged
rapids-bot[bot] merged 8 commits intorapidsai:branch-23.08from Jul 18, 2023
Merged
[BUG] Fix namesapce to default_hash and hash_functions#3711rapids-bot[bot] merged 8 commits intorapidsai:branch-23.08from
rapids-bot[bot] merged 8 commits intorapidsai:branch-23.08from
Conversation
Update concurrent_unordered_map.cuh to include hash_functions.cuh from cudf/hashing/detail
naimnv
changed the title
naimnv
changed the title
naimnv
changed the title
naimnv
changed the title
naimnv
changed the title
seunghwak
reviewed
Jul 17, 2023
| template <typename Key, | ||
| typename Element, | ||
| typename Hasher = cudf::detail::default_hash<Key>, | ||
| typename Hasher = cudf::hashing::detail::default_hash<Key>, |
Contributor
There was a problem hiding this comment.
Should we use cudf's hash function? In other places, we are using cuco's hash function (and you may check whether cudf's hash function is actually an alias of cuco's hash function).
Contributor
There was a problem hiding this comment.
Oh, this isn't cugraph main code, this is libcugraph_etl, yeah... just disregard the comment.
seunghwak
approved these changes
Jul 17, 2023
naimnv
changed the title
naimnv
changed the title
naimnv
changed the title
ChuckHastings
approved these changes
Jul 18, 2023
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix namesapce to default_hash and hash_functions