Promote Datasets to stable and clean-up unit tests#3712
Merged
rapids-bot[bot] merged 94 commits intorapidsai:branch-23.08from Jul 28, 2023
Merged
Promote Datasets to stable and clean-up unit tests#3712rapids-bot[bot] merged 94 commits intorapidsai:branch-23.08from
Datasets to stable and clean-up unit tests#3712rapids-bot[bot] merged 94 commits intorapidsai:branch-23.08from
Conversation
Promote datasets
…e using soon-to-be deleted karate variants from datasets API
…u/cugraph into stable-datasets-notebooks
Merge changes to Notebooks and Docstrings
This reverts commit 0e7e881.
Update concurrent_unordered_map.cuh to include hash_functions.cuh from cudf/hashing/detail
…on due to filenames originally having hyphens
rlratzel
requested changes
Jul 27, 2023
Contributor
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
Getting close! I like the new tests to verify the meta-data. Those will be especially useful if we add new datasets. I mainly had a few issues with the new descriptions.
python/cugraph/cugraph/datasets/metadata/karate_asymmetric.yaml
Outdated
Show resolved
Hide resolved
python/cugraph/cugraph/datasets/metadata/toy_graph_undirected.yaml
Outdated
Show resolved
Hide resolved
Closed
ajschmidt8
approved these changes
Jul 27, 2023
Member
ajschmidt8
left a comment
ajschmidt8
left a comment
There was a problem hiding this comment.
Approving ops-codeowner file changes
rlratzel
approved these changes
Jul 28, 2023
Contributor
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
This PR fixes the `build.yaml` workflow. The `node_type` reusable workflow input was placed incorrectly in #3712. Skipping CI since this file isn't tested in PRs. [skip ci]
ajschmidt8
added a commit
that referenced
this pull request
Jul 28, 2023
This PR fixes the `build.yaml` workflow. The `node_type` reusable workflow input was placed incorrectly in #3712. Skipping CI since this file isn't tested in PRs. [skip ci]
nv-rliu
added a commit
to nv-rliu/cugraph-gnn
that referenced
this pull request
Jul 15, 2025
Addresses #3675 and #3706 This PR moves the `datasets` API from experimental to stable. Users can now do: ```python from cugraph.datasets import karate G = karate.get_graph() ``` The existing `experimental.datasets` package has been updated with the `promoted_experimental_warning_wrapper()`. All notebooks, docstrings, and unit test dependencies on `datasets` have been updated to use the stable API. This PR also removes the networkx warning suppression from the unit tests. Authors: - ralph (https://github.com/nv-rliu) - Naim (https://github.com/naimnv) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Rick Ratzel (https://github.com/rlratzel) URL: rapidsai/cugraph#3712
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #3675 and #3706
This PR moves the
datasetsAPI from experimental to stable. Users can now do:The existing
experimental.datasetspackage has been updated with thepromoted_experimental_warning_wrapper(). All notebooks, docstrings, and unit test dependencies ondatasetshave been updated to use the stable API.This PR also removes the networkx warning suppression from the unit tests.