Switch to new wheel building pipeline#3731
Switch to new wheel building pipeline#3731rapids-bot[bot] merged 6 commits intorapidsai:branch-23.08from
Conversation
vyasr
added
improvement
|
/merge |
ajschmidt8
left a comment
ajschmidt8
left a comment
There was a problem hiding this comment.
Leaving a post-merge review
| #!/bin/bash | ||
| # Copyright (c) 2023, NVIDIA CORPORATION. | ||
|
|
||
| set -eoxu pipefail |
There was a problem hiding this comment.
| set -eoxu pipefail | |
| set -euo pipefail |
Do we need the -x here? Or can we keep it consistent with the other scripts?
| #!/bin/bash | ||
| # Copyright (c) 2023, NVIDIA CORPORATION. | ||
|
|
||
| set -eoxu pipefail |
There was a problem hiding this comment.
| set -eoxu pipefail | |
| set -euo pipefail |
Do we need the -x here? Or can we keep it consistent with the other scripts?
| #!/bin/bash | ||
| # Copyright (c) 2023, NVIDIA CORPORATION. | ||
|
|
||
| set -eoxu pipefail |
There was a problem hiding this comment.
| set -eoxu pipefail | |
| set -euo pipefail |
Do we need the -x here? Or can we keep it consistent with the other scripts?
|
|
||
| RAPIDS_PY_CUDA_SUFFIX="$(rapids-wheel-ctk-name-gen ${RAPIDS_CUDA_VERSION})" | ||
|
|
||
| bash ci/release/apply_wheel_modifications.sh ${version_override} "-${RAPIDS_PY_CUDA_SUFFIX}" |
There was a problem hiding this comment.
Can we remove the bash keyword here?
This will require that the called script has a proper shebang (#!/bin/bash) and is executable (chmod +x <file>).
| arch=$(uname -m) | ||
| if [[ "${arch}" == "x86_64" ]]; then | ||
| pushd ./datasets | ||
| bash ./get_test_data.sh |
There was a problem hiding this comment.
Can we remove the bash keyword here?
This will require that the called script has a proper shebang (#!/bin/bash) and is executable (chmod +x <file>).
| arch=$(uname -m) | ||
| if [[ "${arch}" == "x86_64" ]]; then |
There was a problem hiding this comment.
| arch=$(uname -m) | |
| if [[ "${arch}" == "x86_64" ]]; then | |
| if [[ "$(arch)" == "aarch64" && ${RAPIDS_BUILD_TYPE} == "pull-request" ]]; then |
arch and uname -m return the same value, so this can be shortened.
4 participants
Moves the wheel build and test logic out of the workflow into the repo. This matches conda tests more closely and allows each repo to manage its own wheels more easily.