Fixes KeyError for get_two_hop_neighbors when called with a small start vertices list#3778
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-23.10from Aug 12, 2023
Conversation
…_per_worker() and get_persisted_df_worker_map(), minor refactor to get_two_hop_neighbors(), clean up imports
BradReesWork
approved these changes
Aug 12, 2023
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3745
This PR adds updates to replace the
get_distributed_data()call withpersist_dask_df_equal_parts_per_worker()andget_persisted_df_worker_map()to avoid a problem whereget_distributed_data()does not distribute data properly across all workers. This resulted in aKeyErrorwhen the data was accessed via worker, when that worker was not a key in the map.More details are in the linked issue.
This PR also does minor refactoring in
get_two_hop_neighbors()and reorganizes the imports according to PEP 8.Tested manually on a 4-GPU system, where the problem described in #3745 was reproduced, the change in the PR applied and re-run, and the error no longer occurring.