cuGraph-PyG Loader Improvements#3795
Merged
rapids-bot[bot] merged 32 commits intorapidsai:branch-23.10from Sep 25, 2023
Merged
Conversation
alexbarghi-nv
added
improvement
…alexbarghi-nv/cugraph into cugraph-pyg-loader-improvements
…alexbarghi-nv/cugraph into cugraph-pyg-loader-improvements
VibhuJawa
reviewed
Aug 25, 2023
Member
VibhuJawa
left a comment
VibhuJawa
left a comment
There was a problem hiding this comment.
The changes look good to me, just have asked for a bunch of clarifications.
Co-authored-by: Vibhu Jawa <vibhujawa@gmail.com>
Member
Author
|
Based on feedback from @VibhuJawa , this PR is going back to draft while I work on improvements |
BradReesWork
requested changes
Aug 30, 2023
…alexbarghi-nv/cugraph into cugraph-pyg-loader-improvements
VibhuJawa
suggested changes
Aug 30, 2023
Member
VibhuJawa
left a comment
VibhuJawa
left a comment
There was a problem hiding this comment.
Code changes mostly look good, requested some changes to improve code clarity and readability.
VibhuJawa
reviewed
Aug 30, 2023
…alexbarghi-nv/cugraph into cugraph-pyg-loader-improvements
rlratzel
reviewed
Sep 21, 2023
Contributor
rlratzel
left a comment
rlratzel
left a comment
There was a problem hiding this comment.
I scanned it and only found two things that jumped out to me. Vibhu and Tingyu would be able to provide a more thorough review.
acostadon
reviewed
Sep 22, 2023
acostadon
reviewed
Sep 22, 2023
acostadon
approved these changes
Sep 22, 2023
Contributor
acostadon
left a comment
acostadon
left a comment
There was a problem hiding this comment.
Looks great as much as I understood. Just saw aplace where I wasn't sure what wasn't working due to the fixme
Member
|
/merge |
BradReesWork
approved these changes
Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates various speed improvements tested while running performance benchmarks. Avoids copying batch data, removes redundant data loading code, simplifies and improves de-offsetting, even though that is now being bypassed entirely for homogeneous graphs. Removes extra host to device copy. Properly flips the src/dst columns in the returned
HeteroDataminibatch objects, avoid exposing this to the end user.I've confirmed this cuts the MFG time by a factor of 4.
Closes #3807