Skip to content

Support drop_last Argument in cuGraph-PyG Loader#3995

Merged
rapids-bot[bot] merged 48 commits intorapidsai:branch-23.12from
alexbarghi-nv:drop-last
Nov 20, 2023
Merged

Support drop_last Argument in cuGraph-PyG Loader#3995
rapids-bot[bot] merged 48 commits intorapidsai:branch-23.12from
alexbarghi-nv:drop-last

Conversation

@alexbarghi-nv
Copy link
Member

@alexbarghi-nv alexbarghi-nv commented Nov 12, 2023

Supports the drop_last argument in cuGraph-PyG for better compatibility with native PyG workflows.

Closes #3949

Merge after #3985

alexbarghi-nv and others added 30 commits November 1, 2023 12:26
Co-authored-by: Ray Douglass <3107146+raydouglass@users.noreply.github.com>
Co-authored-by: Tingyu Wang <tingyuw@nvidia.com>
@alexbarghi-nv alexbarghi-nv requested review from a team as code owners November 12, 2023 18:24
@alexbarghi-nv
Copy link
Member Author

/ok to test

@alexbarghi-nv alexbarghi-nv added the Blocked Cannot progress due to external reasons label Nov 12, 2023
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes around dask, looks good otherwise.

@BradReesWork BradReesWork added this to the 23.12 milestone Nov 15, 2023
Copy link
Member

@tingyu66 tingyu66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments.

Copy link
Member

@tingyu66 tingyu66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge once #3985 is merged intio this. LGTM

@alexbarghi-nv alexbarghi-nv removed the Blocked Cannot progress due to external reasons label Nov 20, 2023
@alexbarghi-nv
Copy link
Member Author

/ok to test

@alexbarghi-nv
Copy link
Member Author

/ok to test

@alexbarghi-nv alexbarghi-nv removed the request for review from a team November 20, 2023 18:09
@alexbarghi-nv
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit f3eecda into rapidsai:branch-23.12 Nov 20, 2023
@alexbarghi-nv alexbarghi-nv deleted the drop-last branch November 20, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[IMP] Accept the shuffle and drop_last arguments in the cuGraph-PyG loader

5 participants