Skip to content

Add support for refinement with uint32_t index type#563

Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.02from
lowener:25.02-refine-type
Jan 13, 2025
Merged

Add support for refinement with uint32_t index type#563
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.02from
lowener:25.02-refine-type

Conversation

@lowener
Copy link
Contributor

@lowener lowener commented Jan 10, 2025

Closes #537.
Needed change for the transition from Raft to cuVS.

@lowener lowener requested a review from a team as a code owner January 10, 2025 14:53
@github-actions github-actions bot added the cpp label Jan 10, 2025
@lowener lowener added non-breaking Introduces a non-breaking change feature request New feature or request labels Jan 10, 2025
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

left one minor comment, but pre-approving since its not a huge deal

Co-authored-by: Ben Frederickson <github@benfrederickson.com>
@lowener
Copy link
Contributor Author

lowener commented Jan 13, 2025

/merge

@rapids-bot rapids-bot bot merged commit 28d9990 into rapidsai:branch-25.02 Jan 13, 2025
53 checks passed
@lowener lowener deleted the 25.02-refine-type branch January 13, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cpp feature request New feature or request non-breaking Introduces a non-breaking change

Development

Successfully merging this pull request may close these issues.

[BUG] refine_device fails to compile for idx_t != matrix_idx

2 participants