Skip to content

Use new rapids-logger library#644

Merged
rapids-bot[bot] merged 19 commits intorapidsai:branch-25.04from
vyasr:feat/rapids_logger_library
Feb 11, 2025
Merged

Use new rapids-logger library#644
rapids-bot[bot] merged 19 commits intorapidsai:branch-25.04from
vyasr:feat/rapids_logger_library

Conversation

@vyasr
Copy link
Contributor

@vyasr vyasr commented Feb 3, 2025

Contributes to rapidsai/build-planning#104.

@vyasr vyasr added breaking Introduces a breaking change improvement Improves an existing functionality labels Feb 3, 2025
@vyasr vyasr self-assigned this Feb 3, 2025
@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 3, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@vyasr vyasr force-pushed the feat/rapids_logger_library branch from fd256ee to 7a50a1a Compare February 3, 2025 23:46
@vyasr
Copy link
Contributor Author

vyasr commented Feb 4, 2025

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Feb 4, 2025

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Feb 4, 2025

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Feb 4, 2025

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Feb 4, 2025

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Feb 4, 2025

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Feb 4, 2025

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Feb 4, 2025

/ok to test

@vyasr
Copy link
Contributor Author

vyasr commented Feb 4, 2025

/ok to test

@vyasr vyasr marked this pull request as ready for review February 4, 2025 22:36
@vyasr vyasr requested review from a team as code owners February 4, 2025 22:36
@vyasr vyasr requested a review from jameslamb February 4, 2025 22:36
@vyasr vyasr requested a review from a team as a code owner February 7, 2025 23:17
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one question, but pre-emptively approving so you can merge when you've addressed it + remove the CI-only testing stuff, without needing another review from me.

@bdice
Copy link
Contributor

bdice commented Feb 11, 2025

/merge

@rapids-bot rapids-bot bot merged commit fe6c1c5 into rapidsai:branch-25.04 Feb 11, 2025
61 checks passed
divyegala pushed a commit to divyegala/cuvs that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Introduces a breaking change ci CMake cpp improvement Improves an existing functionality Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants