[BUG] cuvs-bench data_export fixes#863
Merged
rapids-bot[bot] merged 20 commits intorapidsai:branch-25.08from Jun 16, 2025
Merged
[BUG] cuvs-bench data_export fixes#863rapids-bot[bot] merged 20 commits intorapidsai:branch-25.08from
rapids-bot[bot] merged 20 commits intorapidsai:branch-25.08from
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
cjnolet
approved these changes
May 27, 2025
Member
|
/merge |
Member
|
Given the time crunch and the relative priority of this PR, I'm going to suggest we push to 25.08. |
Contributor
Author
|
Rebased to 25.08 |
bkarsin
pushed a commit
to bkarsin/cuvs
that referenced
this pull request
Jun 19, 2025
- [x] Identify the correct dataframe columns for CPU-only algorithms
- [x] Handle `num_threads` argument in build and search params (present in HDBSCAN and DiskANN benchmarks)
* Do this in a better way by renaming params
Closes rapidsai#796
Closes rapidsai#1001
Authors:
- Tarang Jain (https://github.com/tarang-jain)
- Corey J. Nolet (https://github.com/cjnolet)
Approvers:
- Corey J. Nolet (https://github.com/cjnolet)
URL: rapidsai#863
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
num_threadsargument in build and search params (present in HDBSCAN and DiskANN benchmarks)* Do this in a better way by renaming params
Closes [BUG] cuvs-bench Bug in data_export #796
Closes [BUG] cuvs bench- incorrect path for result dataframe #1001