[java] Utility function for cudaMemcpy#983
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.08from Jun 6, 2025
Merged
[java] Utility function for cudaMemcpy#983rapids-bot[bot] merged 3 commits intorapidsai:branch-25.08from
cudaMemcpy#983rapids-bot[bot] merged 3 commits intorapidsai:branch-25.08from
Conversation
This commit does a minor rephrasing of calls to `cudaMemCpy`.
Prior to this change:
1. Calls to `cudaMemcpy` were using hardcoded / undocumented magic
numbers for the direction of the copy. These have been replaced
an enum that mirrors what is used in the CUDA Runtime call.
2. `cudaMemcpy` would return an error value that needed to be checked
/ converted into a RuntimeError. This has been moved into the
utility function, to reduce the noise at the call site.
This change also includes some minor cleanup of unused imports in the
modified files.
mythrocks
added
improvement
cjnolet
approved these changes
Jun 6, 2025
Contributor
Author
|
(Another case of gtest failures.) |
Member
|
/merge |
github-project-automation
bot
moved this from In Progress
to Done
in Vector Search, ML, & Data Mining Release Board
bkarsin
pushed a commit
to bkarsin/cuvs
that referenced
this pull request
Jun 19, 2025
This commit does a minor rephrasing of calls to `cudaMemCpy`. Prior to this change: 1. Calls to `cudaMemcpy` were using hardcoded / undocumented magic numbers for the direction of the copy. These have been replaced an enum that mirrors what is used in the CUDA Runtime call. 2. `cudaMemcpy` would return an error value that needed to be checked / converted into a RuntimeError. This has been moved into the utility function, to reduce the noise at the call site. This change also includes some minor cleanup of unused imports in the modified files. Authors: - MithunR (https://github.com/mythrocks) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#983
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit does a minor rephrasing of calls to
cudaMemCpy.Prior to this change:
cudaMemcpywere using hardcoded / undocumented magic numbers for the direction of the copy. These have been replaced an enum that mirrors what is used in the CUDA Runtime call.cudaMemcpywould return an error value that needed to be checked / converted into a RuntimeError. This has been moved into the utility function, to reduce the noise at the call site.This change also includes some minor cleanup of unused imports in the modified files.