Add rmm to pylibraft run dependencies, since it is used by Cython.#1656
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-23.08from Jul 19, 2023
Merged
Conversation
cjnolet
approved these changes
Jul 19, 2023
ajschmidt8
approved these changes
Jul 19, 2023
jakirkham
approved these changes
Jul 19, 2023
Contributor
|
/merge |
loulankxh
pushed a commit
to loulankxh/raft
that referenced
this pull request
Oct 14, 2025
…apidsai#1656) There is a build error in rapidsai/cugraph#3456: ``` $PREFIX/lib/python3.9/site-packages/pylibraft/common/handle.pxd:47:8: 'cuda_stream_view' is not a type identifier ``` pylibraft should have a `run` dependency on `rmm` so that Cython users of pylibraft (pylibcugraph in this case) can `cimport` and use pylibraft Cython at build time. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - AJ Schmidt (https://github.com/ajschmidt8) - https://github.com/jakirkham URL: rapidsai#1656
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a build error in rapidsai/cugraph#3456:
pylibraft should have a
rundependency onrmmso that Cython users of pylibraft (pylibcugraph in this case) cancimportand use pylibraft Cython at build time.