Skip to content

Use shared-workflows branch-25.04#2576

Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.04from
bdice:use-branch-25.04-workflows
Feb 7, 2025
Merged

Use shared-workflows branch-25.04#2576
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.04from
bdice:use-branch-25.04-workflows

Conversation

@bdice
Copy link
Contributor

@bdice bdice commented Feb 6, 2025

This completes the migration to NVKS runners now that all libraries have been tested and rapidsai/shared-workflows#273 has been merged.

xref: https://github.com/rapidsai/build-infra/issues/184

@bdice bdice requested a review from a team as a code owner February 6, 2025 23:50
@bdice bdice requested a review from raydouglass February 6, 2025 23:50
@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Feb 6, 2025
@jameslamb jameslamb added non-breaking Non-breaking change and removed non-breaking Non-breaking change labels Feb 7, 2025
@jameslamb
Copy link
Member

jameslamb commented Feb 7, 2025

Label Checker was failing despite having non-breaking and improvement on here.

Screenshot 2025-02-07 at 11 15 16 AM

If I recall correctly (can't find the link right now), this can occasionally happen with rapids-reviser PRs because the PR and its labels are created simultaneously in quick succession, and there's a race condition in when all the data gets reflected back in GitHub's API.

I'll open a rapids-reviser issue about that, I have an idea for how we could avoid that.

I know that modifying the labels causes the check to re-run, so I just removed non-breaking and added it back. And that seemed to fix this.

@jameslamb
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 307e927 into rapidsai:branch-25.04 Feb 7, 2025
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants