Bifurcate Dependency Lists [skip-gpuci]#1073
Merged
ajschmidt8 merged 25 commits intobranch-22.10from Sep 6, 2022
Merged
Conversation
27a6b41 to
370d8e6
Compare
bdice
reviewed
Jul 29, 2022
Member
|
Is this really a 22.08 PR? |
Member
Author
Nope, I will re-target this PR for |
015013c to
79a082f
Compare
bdice
reviewed
Aug 16, 2022
bdice
reviewed
Sep 2, 2022
bdice
reviewed
Sep 2, 2022
bdice
reviewed
Sep 2, 2022
bdice
approved these changes
Sep 2, 2022
Collaborator
bdice
left a comment
There was a problem hiding this comment.
All looks good to me. Thanks @ajschmidt8 for your hard work and many iterations!
raydouglass
approved these changes
Sep 6, 2022
This was referenced Sep 8, 2022
ajschmidt8
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Nov 8, 2022
This PR uses the [`rapids-dependency-file-generator`](https://github.com/rapidsai/dependency-file-generator/) to handle sourcing dependencies. Similar to rapidsai/rmm#1073, this PR introduces a GitHub Action that enforces consistency between the new `dependencies.yaml` file and the generated conda environment for developers. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - GALI PREM SAGAR (https://github.com/galipremsagar)
ajschmidt8
added a commit
to rapidsai/raft
that referenced
this pull request
Dec 7, 2022
This PR uses the [`rapids-dependency-file-generator`](https://github.com/rapidsai/dependency-file-generator/) to handle sourcing dependencies. Similarly to rapidsai/rmm#1073 and rapidsai/cudf#11674, this PR introduces a GitHub Action that enforces consistency between the new `dependencies.yaml` file and the generated conda environment for developers. Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Bradley Dice (https://github.com/bdice) - Corey J. Nolet (https://github.com/cjnolet)
loulankxh
pushed a commit
to loulankxh/raft
that referenced
this pull request
Oct 14, 2025
This PR uses the [`rapids-dependency-file-generator`](https://github.com/rapidsai/dependency-file-generator/) to handle sourcing dependencies. Similarly to rapidsai/rmm#1073 and rapidsai/cudf#11674, this PR introduces a GitHub Action that enforces consistency between the new `dependencies.yaml` file and the generated conda environment for developers. Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - Bradley Dice (https://github.com/bdice) - Corey J. Nolet (https://github.com/cjnolet)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR uses rapids-dependency-file-generator along with a new
dependencies.yamlfile to bifurcate the existing dependency lists in theconda/environmentsdirectory.rapids-dependency-file-generatorwill generatecondaenvironment files based on the contents of the newdependencies.yamlfile (see rapidsai/dependency-file-generator for more details). There is also a new GitHub Action that runs a shared workflow (which lives here) to ensure that the generated dependency files are up-to-date in each PR. This shared workflow can easily be implemented across other RAPIDS repositories.Why is this PR Needed?
This PR is necessary to support some upcoming changes in CI. We've recently created some new, slimmer CI images (~450MB vs. the current 6.5GB) in anticipation of the move to GitHub Actions. These new images omit the large dependency packages (i.e.
rapids-{build,notebook,doc}-env) from the rapidsai/integration repository, which will eventually be deprecated and deleted entirely. One of the consequences of removing theintegrationpackages from our CI images is that commonly used test dependencies (i.e.pytest) are no longer included in the CI images by default. Therefore, we need to ensure that each repository has a list of the dependencies that are required to test its respective libraries. A similar list will also be needed in other repositories for JupyterLab Notebook dependencies (which will be utilized in ourruntimeend-user images), but that list does not apply tormm.Impacts of these Changes
The changes in this PR impact developers and CI as follows:
Developers
Developers should now update the dependencies in the
dependencies.yamlfile instead of the generated dependency files. If they accidentally update the generated dependency files, the new GitHub Action will fail. At this point, the developer will need to installrapids-dependency-file-generatorand run it from the project's root directory. For example:This step can also be implemented as a pre-commit hook.
CI
The new GitHub Action CI process will use the dependencies in the
testlist independencies.yamlto create a new test environment forrmm/librmmin CI. For example:Additional Information
The new GitHub Action will enforce that an
allenvironment (under thefiles.allkey) is included in thedependencies.yamlfile and that it includes all of the dependency lists in thedependencies.condaanddependencies.conda_and_requirementssections. This is enforced in the shared workflow here. It exists to provide some standardization across the RAPIDS libraries and will eventually replace therapids-{build,notebook,doc}-envpackages in ourdevelend-user images.